Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

  • we want to use internal ChildProcess module over node's child process module
  • some code for spawning the language server is duplicated between the workspace server and the amazon q server

Solution

  • use internal ChildProcess module and de-dup the common language server spawning code

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested review from a team as code owners January 15, 2025 16:23
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@jpinkney-aws jpinkney-aws merged commit 45a1ab9 into aws:feature/amazonqLSP Jan 17, 2025
12 of 17 checks passed
@jpinkney-aws jpinkney-aws deleted the child-process branch January 17, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants